fix: check for delete modules dir in sub-project#8967
Merged
Conversation
KSXGitHub
commented
Jan 13, 2025
deps/status/src/checkDepsStatus.ts
Outdated
| return { | ||
| project, | ||
| manifestStats, | ||
| modulesDirStats: await modulesDirStatPromise, |
Contributor
Author
There was a problem hiding this comment.
This await can be delayed until modifiedProjects, but it would make the code more complicated. Should we do that?
Member
There was a problem hiding this comment.
if it is fast enough as is then I am fine if you leave it
4 tasks
zkochan
reviewed
Jan 14, 2025
deps/status/src/checkDepsStatus.ts
Outdated
Comment on lines
+177
to
+178
| ...project.manifest.optionalDependencies, // TODO: how to detect when to install optional? | ||
| ...project.manifest.devDependencies, // TODO: handle --prod properly |
Member
There was a problem hiding this comment.
I think it is OK to just always check all. What is the worst that could happen? We won't have a fast repeat install? But that's only on partial install, which is a rare scenario.
Contributor
Author
There was a problem hiding this comment.
It is also used by verify-deps-before-run.
zkochan
approved these changes
Jan 25, 2025
zkochan
deleted the
install-in-sub-package-does-not-install-any-dependencies-8959
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8959