Conversation
…un` assigns silent loglevel
|
💖 Thanks for opening this pull request! 💖 |
zkochan
approved these changes
Jul 14, 2024
|
Congrats on merging your first pull request! 🎉🎉🎉 |
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7608
I originally reported the issue a few months ago. Now it's blocking our infrastructure plans so I put the time to fix it myself. This only adds a line that is likely forgotten in the original implementation.
The bug was that if you have recursive runs to
pnpmor if a script inpackage.jsoncallspnpmagain (which probably is the same as recursive run) then the calls don't respect the--silentargument.I found the commit by @zkochan from 4 years ago that made
silentmode work: 76aaead#diff-c0a21f7925dd7f02d9af2aeb8297f31b6eb5a6bbe684bd7e2344a34f26bbd4e3And what I can see there is that the
lifeCycleOptionsinrun.tshas this:pnpm/exec/plugin-commands-script-runners/src/run.ts
Line 248 in a2e9bdc
And the
lifeCycleOptionsinrunRecursive.tsdidn't have this. Once I added it all worked out! 🎉