Conversation
gluxon
commented
Jun 16, 2024
pnpm/src/main.ts
Outdated
| engineStrict: config.engineStrict, | ||
| nodeVersion: config.nodeVersion ?? config.useNodeVersion, | ||
| patterns: cliOptions['workspace-packages'] ?? config.workspacePackagePatterns, | ||
| patterns: config.workspacePackagePatterns ?? ['.', '**'], |
Member
Author
There was a problem hiding this comment.
This is something I noticed in one of the other PRs too. The patterns field here could accidentally be undefined, but TypeScript never caught this because cliOptions is Record<string, any>.
I think this only comes up in tests where workspaceDir is directly passed rather than through the findWorkspaceDir function. In production, the findWorkspaceDir verifies pnpm-workspace.yaml exists, so config.workspacePackagePatterns is defined.
I added ?? ['.', '**'] to match the existing behavior, but I think we should default to ?? [] in this case so broken tests fail.
gluxon
changed the title
--workspace-packages CLI over pnpm-workspace.yaml in more cases
zkochan
approved these changes
Jun 16, 2024
gluxon
commented
Jun 17, 2024
| engineStrict?: boolean | ||
| nodeVersion?: string | ||
| patterns: string[] | ||
| patterns?: string[] |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Implementing feedback from: #8213 (comment)
Let's read
cliOptions['workspace-packages']when computingconfig.workspacePackagePatterns, rather than doing it later inpnpm/src/main.ts.