Skip to content

fix: a filtered install should update the lockfile first#8183

Merged
zkochan merged 14 commits intomainfrom
fix/8165
Jun 12, 2024
Merged

fix: a filtered install should update the lockfile first#8183
zkochan merged 14 commits intomainfrom
fix/8165

Conversation

@zkochan
Copy link
Copy Markdown
Member

@zkochan zkochan commented Jun 7, 2024

close #8165

@zkochan zkochan marked this pull request as ready for review June 10, 2024 09:11
@zkochan zkochan requested a review from a team June 12, 2024 00:44
@jakebailey
Copy link
Copy Markdown
Member

In #8020 (comment), you mention:

If the lockfile is not up-to-date, when a filtered install happens, we should do a non-filtered full resolution only install first.

If lockfiles are disabled, will this still happen? DT doesn't use a lockfile, but relies on filtered installs for improved performance as most people do not work on anything but a few packages. Hoping that if a full install does happen, it doesn't affect this situation too much.

Copy link
Copy Markdown
Member

@gluxon gluxon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving! 👍

For those following along, a filtered install previously only updated the part of the lockfile included in the filter, resulting in an inconsistent lockfile.

@jakebailey's question is a good one. Also curious how the new behavior will work if there's no lockfile in the first place.

@zkochan
Copy link
Copy Markdown
Member Author

zkochan commented Jun 12, 2024

I am going to disable this behaviour for the case when there is no lockfile.

@zkochan
Copy link
Copy Markdown
Member Author

zkochan commented Jun 12, 2024

If this change is required for catalogs, then we'll have to disable catalogs too for projects without lockfiles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Filtered install should work only on an up-to-date lockfile

3 participants