Conversation
This reverts commit 6d80664.
KSXGitHub
force-pushed
the
pnpx-redownload-reinstall-every-time-5277
branch
from
ccff5c2 to
ffefa7e
Compare
KSXGitHub
force-pushed
the
pnpx-redownload-reinstall-every-time-5277
branch
from
e63f9af to
5abba52
Compare
KSXGitHub
force-pushed
the
pnpx-redownload-reinstall-every-time-5277
branch
from
5abba52 to
bb3a336
Compare
KSXGitHub
force-pushed
the
pnpx-redownload-reinstall-every-time-5277
branch
2 times, most recently
from
07535d5 to
d1fb986
Compare
zkochan
left a comment
zkochan
left a comment
There was a problem hiding this comment.
I think overall it looks fine. I will spend more time reviewing it later because it is a lot of changes. However, I think the approach is fine.
| } | ||
| } | ||
| try { | ||
| await fs.symlink(newPrefix, cacheLink, 'junction') |
There was a problem hiding this comment.
Use the symlink-dir library. It is already used in many places for creating symlinks on POSIX and junctions on Windows.
|
tests fail after your change |
KSXGitHub
force-pushed
the
pnpx-redownload-reinstall-every-time-5277
branch
from
3c9a3db to
91e2685
Compare
|
The test fails on Windows with Node.js 21 due to some issue released in node.js v21.5.0. This might fix the issue as it seems to happen only when the path is long: nodejs/node#51097 |
| "@pnpm/plugin-commands-store": patch | ||
| --- | ||
|
|
||
| Added cache for `pnpm dlx` [#5277](https://github.com/pnpm/pnpm/issues/5277). |
There was a problem hiding this comment.
Where is it cached and for how long?
There was a problem hiding this comment.
5 minutes by default. Add dlx-cache-max-age=N to .npmrc to set it to N minutes.
There was a problem hiding this comment.
Thanks! The docs should probably be updated here: https://pnpm.io/cli/dlx
3 participants
Fixes #5277
TODO:
dlx.e2e.tsandrun.ts.cleanExpiredCache.ts.cleanExpiredCache.test.ts.cleanExpiredCachetocleanExpiredDlxCache.storePrune.ts.run.ts(as a CLI invoker).dlxwith cache that is expired but still exist.dlxin parallel with cache that is expired but still exist.dlx.ts: async fs methods.