refactor(lockfile-file): Abstract LockfileFile to Lockfile conversion #4824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gluxon
commented
May 30, 2022
| /** | ||
| * Reverts changes from the "forceSharedFormat" write option if necessary. | ||
| */ | ||
| function convertFromLockfileFileMutable (lockfileFile: LockfileFile): Lockfile { |
Member
Author
There was a problem hiding this comment.
This block was moved with no changes.
packages/lockfile-file/src/read.ts
Outdated
| prefix, | ||
| }) | ||
| } | ||
| return { lockfile: lockfileFile as Lockfile, hadConflicts } |
Member
Author
There was a problem hiding this comment.
Moving this type assertion was the main motivation of the PR.
gluxon
force-pushed
the
lockfilefile-read-type-safety
branch
from
e9b6bf9 to
61b6d62
Compare
gluxon
changed the title
Member
Author
|
CI checks currently failing due to #4825. |
zkochan
approved these changes
Jun 1, 2022
This allows the `LockfileFile` to `Lockfile` conversion to be slightly better abstracted since the type assertion is now tightly grouped with the logic performing the conversion. This will be useful for pnpm#4725, which operates off of the `Lockfile` type to perform additional conversions.
gluxon
force-pushed
the
lockfilefile-read-type-safety
branch
from
61b6d62 to
90bf15e
Compare
This was referenced Jun 4, 2022
Closed
This was referenced Jul 2, 2022
This was referenced Jul 10, 2022
This was referenced Jul 18, 2022
This was referenced Jul 31, 2022
This was referenced Aug 8, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the
LockfileFiletoLockfileconversion to be slightly better abstracted since the type assertion is now tightly grouped with the logic performing the conversion.This will be useful for #4725, which operates off of the
Lockfiletype to perform additional conversions.