Skip to content

fix: pnpm pre-compiled binaries crash when NODE_MODULES is set #4823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zkochan merged 1 commit into from
May 30, 2022
Merged

fix: pnpm pre-compiled binaries crash when NODE_MODULES is set #4823

zkochan merged 1 commit into from
May 30, 2022

Conversation

@gluxon
Copy link
Member

@gluxon gluxon commented May 30, 2022 •
edited
Loading

Fixes #4319

This was fixed upstream in pkg-fetch 3.4

Before

~/Developer/pnpm/packages/artifacts/macos-arm64
❯ NODE_OPTIONS="--max-old-space-size=4096" ./pnpm

❯ echo $?           
4

After

~/Developer/pnpm/packages/artifacts/macos-arm64
❯ NODE_OPTIONS="--max-old-space-size=4096" ./pnpm
Version 7.1.6 (compiled to binary; bundled Node.js v14.19.2)
Usage: pnpm [command] [flags]
       pnpm [ -h | --help | -v | --version ]

@gluxon gluxon marked this pull request as ready for review May 30, 2022 18:28
@gluxon gluxon requested a review from zkochan as a code owner May 30, 2022 18:28
@gluxon
Copy link
Member Author

gluxon commented May 30, 2022

If a rebase in https://github.com/zkochan/pkg is preferred I can start a PR for that.

@zkochan zkochan merged commit 7fb1ac0 into pnpm:main May 30, 2022
zkochan pushed a commit that referenced this pull request May 31, 2022
@gluxon @zkochan
fix: pnpm pre-compiled binaries crash when NODE_MODULES is set (#4823)
0db15ee 
This was fixed upstream in pkg-fetch 3.4:
https://github.com/vercel/pkg-fetch/releases/tag/v3.4

close #4319
This was referenced Jun 4, 2022
Merged
Merged
Merged
Closed
Closed
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Open
Merged
Closed
Closed
Merged
Closed
Closed
Merged
Merged
Merged
This was referenced Jul 2, 2022
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Jul 10, 2022
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
This was referenced Jul 18, 2022
Merged
Merged
@gluxon gluxon deleted the pkg-fetch-3.4.1 branch July 20, 2022 05:29
This was referenced Jul 31, 2022
Closed
Closed
Merged
This was referenced Aug 8, 2022
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
@renovate renovate bot mentioned this pull request Aug 16, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zkochan zkochan zkochan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

vercel/pkg distributed pnpm crashes when NODE_OPTIONS="--max-old-space-size=4096" is set

2 participants

@gluxon @zkochan