Skip to content

feat: workspace:^ and workspace:~ aliases (#3116) - #3368

Merged
zkochan merged 5 commits into
pnpm:mainfrom
javier-garcia-meteologica:workspace_aliases
Apr 21, 2021
Merged

zkochan merged 5 commits into
pnpm:mainfrom
javier-garcia-meteologica:workspace_aliases

Conversation

@javier-garcia-meteologica

Copy link
Copy Markdown
Contributor

This is an attempt to support for workspace:^ and workspace:~ aliases.

@zkochan zkochan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add changesets

'is-positive': '1.0.0',
'lodash.delay': '~4.1.0',
odd: 'workspace:is-odd@*',
rd: 'workspace:ramda@^',

@javier-garcia-meteologica javier-garcia-meteologica Apr 20, 2021 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm having problem with this dependency, the test passes if I remove rd: 'workspace:ramda@^' and ramda references. The error message says that is-negative could not be found.

Cannot resolve workspace protocol of dependency "is-negative" because this dependency is not installed

Do you know how could I troubleshoot this error?

@javier-garcia-meteologica javier-garcia-meteologica Apr 20, 2021 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fixed now. Among the things that I modified to make it work, I had to change the versions of test packages to match those specified in verdaccio/node_modules/storage-cache.

Is this ok? Or am I just fooling myself?

Comment thread packages/npm-resolver/src/index.ts Resolved
@zkochan zkochan added this to the v6.2 milestone Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants