-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
feat(view): show deprecation warning and bin info #12271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
6f570f7
feat(view): show deprecation warning
dasa d577c08
feat(view): show bin(s)
dasa 521da3e
chore: add changeset
dasa 36a825c
test: use fixtures
dasa c85cfed
fix: handle string form of `bin`
dasa 01eb3fc
Merge branch 'main' into view-cmd
dasa 1599363
chore: make sure `info.name` exists
dasa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@pnpm/deps.inspection.commands": patch | ||
| --- | ||
|
|
||
| Update `view` command to show deprecation warning and available bins. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -124,6 +124,16 @@ test('view: text output includes header with name@version', async () => { | |
| expect(firstLine).toContain('[email protected]') | ||
| }) | ||
|
|
||
| test('view: text output includes bin from object', async () => { | ||
| const result = await view.handler(VIEW_OPTIONS as unknown as Config & ConfigContext, ['@pnpm.e2e/[email protected]']) as string | ||
| expect(result).toMatch(/^bin: t/m) | ||
| }) | ||
|
|
||
| test('view: text output includes bin from string', async () => { | ||
| const result = await view.handler(VIEW_OPTIONS as unknown as Config & ConfigContext, ['@pnpm.e2e/hello-world-js-bin']) as string | ||
| expect(result).toMatch(/^bin: hello-world-js-bin/m) | ||
| }) | ||
|
|
||
| test('view: text output includes dist section', async () => { | ||
| const result = await view.handler(VIEW_OPTIONS as unknown as Config & ConfigContext, ['[email protected]']) as string | ||
| expect(result).toContain('.tarball:') | ||
|
|
@@ -143,6 +153,11 @@ test('view: text output for package with dependencies shows deps count', async ( | |
| expect(firstLine).not.toContain('deps: none') | ||
| }) | ||
|
|
||
| test('view: text output for deprecated package shows deprecation', async () => { | ||
| const result = await view.handler(VIEW_OPTIONS as unknown as Config & ConfigContext, ['@pnpm.e2e/[email protected]']) as string | ||
| expect(result).toMatch(/^DEPRECATED! - .+/m) | ||
| }) | ||
|
dasa marked this conversation as resolved.
|
||
|
|
||
| test('view: text output for package without dependencies shows deps: none', async () => { | ||
| const result = await view.handler(VIEW_OPTIONS as unknown as Config & ConfigContext, ['[email protected]']) as string | ||
| const firstLine = result.split('\n')[0] | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.