config/reader/test/index.ts (1)

1108-1160: ⚡ Quick win

Add an explicit conflict-precedence test for dual env forms.

Current cases validate each env form independently, but not when both are set with different values. A single precedence test here would lock deterministic behavior for future refactors (especially around .npmrc selection).

Proposed test addition

+test('getConfig() resolves deterministic precedence when both PNPM_CONFIG_USERCONFIG and pnpm_config_userconfig are set', async () => {
+  prepareEmpty()
+  fs.mkdirSync('user-home')
+  fs.writeFileSync(path.resolve('user-home', 'upper.npmrc'), 'registry = https://upper.example.test', 'utf-8')
+  fs.writeFileSync(path.resolve('user-home', 'lower.npmrc'), 'registry = https://lower.example.test', 'utf-8')
+
+  const { config } = await getConfig({
+    cliOptions: {},
+    env: {
+      ...env,
+      PNPM_CONFIG_USERCONFIG: path.resolve('user-home', 'upper.npmrc'),
+      pnpm_config_userconfig: path.resolve('user-home', 'lower.npmrc'),
+    },
+    packageManager: {
+      name: 'pnpm',
+      version: '1.0.0',
+    },
+  })
+
+  // Assert the intended winner explicitly.
+  expect(config.userConfig).toEqual({ registry: 'https://lower.example.test' })
+})

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@config/reader/test/index.ts` around lines 1108 - 1160, Add a test that
verifies precedence when both env variants are set with different paths: call
getConfig(...) with env containing both PNPM_CONFIG_USERCONFIG and
pnpm_config_userconfig pointing to two different .npmrc files, then assert which
file wins by checking config.userConfig contents; place this alongside the
existing tests (referencing getConfig and config.userConfig) and ensure the test
creates two distinct user-home directories/files so the expected precedence
behavior is locked in.