Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where pnpm store prune would fail when the store contains Node.js packages. Node.js packages don't have a package.json file in their file index, which caused the previous code to attempt to access a property on undefined, leading to a crash.
- Added a null safety check to skip Node.js packages during pruning
- Added a TODO comment to track future implementation of Node.js package pruning
- Added a changeset documenting the fix
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
store/package-store/src/storeController/prune.ts |
Added null check for pkgFilesIndex['package.json'] before accessing its integrity property to prevent crashes when processing Node.js packages |
.changeset/tidy-teeth-accept.md |
Documents the bug fix for the patch release |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
zkochan
added a commit
that referenced
this pull request
Nov 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #10131