fix: preserve user-defined npm_config_* env vars in lifecycle scripts

felipecrs · felipecrs · commit 71e46de9e8b8 · 2026-06-14T02:00:19.000-03:00
diff --git a/.changeset/preserve-user-npm-config-vars.md b/.changeset/preserve-user-npm-config-vars.md
@@ -0,0 +1,6 @@
+---
+"@pnpm/exec.lifecycle": patch
+"pnpm": patch
+---
+
+User-defined `npm_config_*` environment variables are now preserved during lifecycle script execution. Previously, all `npm_`-prefixed env vars were stripped, which caused user-set variables like `npm_config_platform_arch` to be lost [pnpm/pnpm#12399](https://github.com/pnpm/pnpm/issues/12399).
diff --git a/exec/lifecycle/test/fixtures/inspect-user-npm-config/package.json b/exec/lifecycle/test/fixtures/inspect-user-npm-config/package.json
@@ -0,0 +1,7 @@
+{
+  "name": "inspect-user-npm-config",
+  "version": "1.0.0",
+  "scripts": {
+    "postinstall": "node postinstall.js | test-ipc-server-client ./test.sock"
+  }
+}
diff --git a/exec/lifecycle/test/fixtures/inspect-user-npm-config/postinstall.js b/exec/lifecycle/test/fixtures/inspect-user-npm-config/postinstall.js
@@ -0,0 +1,13 @@
+const value = process.env['npm_config_platform_arch']
+
+switch(value) {
+  case undefined:
+    process.stdout.write('unset')
+    break
+  case '':
+    process.stdout.write('empty string')
+    break
+  default:
+    process.stdout.write(value)
+    break
+}
diff --git a/exec/lifecycle/test/index.ts b/exec/lifecycle/test/index.ts
@@ -76,6 +76,25 @@ test('runLifecycleHook() does not set npm_config env vars', async () => {
   expect(server.getLines()).toStrictEqual(['unset'])
 })
 
+test('runLifecycleHook() preserves user-defined npm_config_* env vars', async () => {
+  const pkgRoot = f.find('inspect-user-npm-config')
+  await using server = await createTestIpcServer(path.join(pkgRoot, 'test.sock'))
+  const { default: pkg } = await import(path.join(pkgRoot, 'package.json'))
+  process.env.npm_config_platform_arch = 'x64'
+  try {
+    await runLifecycleHook('postinstall', pkg, {
+      depPath: '/inspect-user-npm-config/1.0.0',
+      pkgRoot,
+      rootModulesDir,
+      unsafePerm: true,
+    })
+  } finally {
+    delete process.env.npm_config_platform_arch
+  }
+
+  expect(server.getLines()).toStrictEqual(['x64'])
+})
+
 test('runPostinstallHooks()', async () => {
   const pkgRoot = f.find('with-many-scripts')
   await using server = await createTestIpcServer(path.join(pkgRoot, 'test.sock'))
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/pnpm-workspace.yaml b/pnpm-workspace.yaml
@@ -91,7 +91,7 @@ catalog:
   '@pnpm/logger': '^1100.0.0'
   '@pnpm/meta-updater': 2.0.6
   '@pnpm/nopt': ^0.3.1
-  '@pnpm/npm-lifecycle': 1100.0.0-1
+  '@pnpm/npm-lifecycle': https://github.com/pnpm/npm-lifecycle#refs/pull/59/head
   '@pnpm/npm-package-arg': ^2.0.0
   '@pnpm/os.env.path-extender': ^3.0.1
   '@pnpm/patch-package': 0.0.1
