Skip to content

Commit 0d8cb5f

Browse files
committed
refactor: just prepend
1 parent 278e78d commit 0d8cb5f

File tree

3 files changed

+1
-55
lines changed

3 files changed

+1
-55
lines changed

env/plugin-commands-env/src/node.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ import loadJsonFile from 'load-json-file'
1111
import writeJsonFile from 'write-json-file'
1212
import { getNodeMirror } from './getNodeMirror'
1313
import { parseNodeSpecifier } from './parseNodeSpecifier'
14-
import { replaceOrAddNodeIntoBinPaths } from './replaceOrAddNodeIntoBinPaths'
1514

1615
export type NvmNodeCommandOptions = Pick<Config,
1716
| 'bin'
@@ -51,8 +50,6 @@ const nodeFetchPromises: Record<string, Promise<string>> = {}
5150
export async function prepareExecutionEnv (config: NvmNodeCommandOptions, { extraBinPaths, executionEnv }: PrepareExecutionEnvOptions): Promise<PrepareExecutionEnvResult> {
5251
if (!executionEnv?.nodeVersion) return { extraBinPaths: extraBinPaths ?? [] }
5352

54-
const baseDir = getNodeVersionsBaseDir(config.pnpmHomeDir)
55-
5653
let nodePathPromise = nodeFetchPromises[executionEnv.nodeVersion]
5754
if (!nodePathPromise) {
5855
nodePathPromise = getNodeBinDir({
@@ -63,7 +60,7 @@ export async function prepareExecutionEnv (config: NvmNodeCommandOptions, { extr
6360
}
6461

6562
return {
66-
extraBinPaths: replaceOrAddNodeIntoBinPaths(extraBinPaths ?? [], baseDir, await nodePathPromise),
63+
extraBinPaths: [await nodePathPromise, ...extraBinPaths ?? []],
6764
}
6865
}
6966

env/plugin-commands-env/src/replaceOrAddNodeIntoBinPaths.ts

Lines changed: 0 additions & 15 deletions
This file was deleted.

env/plugin-commands-env/test/replaceOrAddNodeIntoBinPaths.test.ts

Lines changed: 0 additions & 36 deletions
This file was deleted.

0 commit comments

Comments
 (0)