Conversation
|
This would effectively render the |
|
Not correct. Nothing changed regarding version. pnpm is installing the specified version of pnpm. Before this change, pnpm was downloaded. This was causing issues. So now the pnpm which installs pnpm is committed to the project. |
|
Ah, I see. I somehow forgot the workings of the code that I wrote/merged myself lol. |
|
Could you release it? I don't know how it is released. |
KSXGitHub
left a comment
There was a problem hiding this comment.
So there are 2 pnpm.js files: One in dist, the other in src/install-pnpm. Is this excessive?
|
it might be why is the dist folder committed at all? |
|
Wait, did you just merge? I was meant to make more review comment! |
|
ok, comment, I'll make another PR |
Step 0: Make sure that you have enabled Two Factor Authentication (2-FA) on GitHub. |
|
Thanks, we'll have to add that to a CONTRIBUTING.md |
The |
|
can we generate it before packing? |
I think there's a command in |
close #44
close #22