update m365 status condition check. Closes #298#301
Merged
Conversation
Member
|
once again thanks @Jwaegebaert for fixing this 👍👍👍 |
Member
|
Ill keep the PR on the queue as its a bigger one, but I'd like to add your recognition so I will add the metadata :-) |
Member
|
Ive been going through al the changes, if its ok, not going to update the metadata with the credit, it may distort the samples authors, instead, ill credit via a different method. Its a great change and sorry it took so long to review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #298
Here I updated the commonly used 'm365 status' condition check from
to the following
@pkbullock, should I also update the
updateDateTimevariables within the sample.json files?