Skip to content

CLI for M365 version for script "Get SharePoint List Or Library Permissions And Export It To CSV"#295

Merged
pkbullock merged 2 commits intopnp:mainfrom
nanddeepn:get-sp-permissions
Jun 5, 2022
Merged

CLI for M365 version for script "Get SharePoint List Or Library Permissions And Export It To CSV"#295
pkbullock merged 2 commits intopnp:mainfrom
nanddeepn:get-sp-permissions

Conversation

@nanddeepn
Copy link
Copy Markdown
Contributor

@nanddeepn
Copy link
Copy Markdown
Contributor Author

@Adam-it
Please review from the CLI for M365 angle.

@Adam-it
Copy link
Copy Markdown
Member

Adam-it commented Jun 2, 2022

#geekJoke I made up just now 😋

- what is the CLI for M365 angle?
- the right one 😉

... I know not funny 😜... unless it is very late and you are like reeeeelly sleepy.. then it works 😉

Copy link
Copy Markdown
Member

@Adam-it Adam-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pulled locally and tested ✅
works nicely ✅
thanks for this contribution 👍
you rock 🤩
@pkbullock awaits your second opinion and processing 🙂

Comment on lines +175 to +176
If ($permissionType -eq 8) {
# Get members of a SharePoint Group
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this condition to check if it is 8 is very specific. It's good we have this little comment here 👍 Thank you for that 🙏
Actually it is because the SharePointGroup enum member has 8 value assigned to it
image
TBH it's a shame that we don't translate it in the CLI response to enum names 🤔 I suppose it may not be that easy 😜. Do you think this may be a good use case to open and issue for a improvement to the CLI for M365 and lets check if this could be done 🤔?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Adam-it for your review.
The issue with possible resolution is created pnp/cli-microsoft365#3379

@pkbullock pkbullock merged commit 033de8e into pnp:main Jun 5, 2022
@pkbullock
Copy link
Copy Markdown
Member

@nanddeepn, thank you!! 👏😊 This should be live shortly 😊

@nanddeepn nanddeepn deleted the get-sp-permissions branch June 9, 2022 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CLI for M365 version for script "Get SharePoint List Or Library Permissions And Export It To CSV"

3 participants