Skip to content

@pnp/graph: Added support for me/onenote/notebooks#37

Merged
patrick-rodgers merged 2 commits intopnp:devfrom
olemp:me-onenote-notebooks
Mar 16, 2018
Merged

@pnp/graph: Added support for me/onenote/notebooks#37
patrick-rodgers merged 2 commits intopnp:devfrom
olemp:me-onenote-notebooks

Conversation

@olemp
Copy link
Copy Markdown
Contributor

@olemp olemp commented Mar 9, 2018

Category

  • Bug fix
  • New feature
  • New sample
  • Documentation update

What's in this Pull Request?

Support for me/onenote/notebooks

@patrick-rodgers
Copy link
Copy Markdown
Member

So this PR and #38 now have conflicts based on #32. Do you want to update your PRs to fix those conflicts?

@olemp
Copy link
Copy Markdown
Contributor Author

olemp commented Mar 9, 2018

I'll take a look on monday @patrick-rodgers 🍔

@olemp
Copy link
Copy Markdown
Contributor Author

olemp commented Mar 12, 2018

FIxed 🔨

@patrick-rodgers
Copy link
Copy Markdown
Member

Thanks, will get this merged shortly!

@patrick-rodgers
Copy link
Copy Markdown
Member

patrick-rodgers commented Mar 16, 2018

Were you able to test the add notebook method successfully? I am trying as part of the merge and keep getting back errors. Not sure it is this code as much as a service issue.

[Edit] - I figured out my problem, but am still curious if you were able to successful test?

@patrick-rodgers patrick-rodgers merged commit 2035ea2 into pnp:dev Mar 16, 2018
@olemp olemp deleted the me-onenote-notebooks branch March 16, 2018 15:22
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants