Adding support for Adal auth, Microsoft Teams support, fixes#32
Adding support for Adal auth, Microsoft Teams support, fixes#32patrick-rodgers merged 5 commits intopnp:devfrom patrick-rodgers:dev
Conversation
…ode cleanup, fixes for banner and clean task
|
@koltyakov have a quick look at this when you get a chance, please. Adds adal support and teams are the big things. New doc here. |
koltyakov
left a comment
There was a problem hiding this comment.
Looks great! Can't wait trying it on a project.
|
Isn't |
|
@eirikb - that is the package they published. Ideally it wouldn't be named that and would just have the core adal stuff, but that is the official adaljs package that is available. I am not sure what you mean by SPO requires keys? The below works for an app id registered with SPO permissions. sp.setup({
sp: {
fetchClientFactory: () => {
return new AdalClient(
"ac68ea8f-79gc-47a7-a292-158c97331c66",
"{tenant}.onmicrosoft.com",
"https://{tenant}.sharepoint.com/_forms/spfxsinglesignon.aspx");
},
},
});
const r = await sp.web.get();
console.log(r); |
|
@patrick-rodgers is that for adal and user login? I'm thinking about from nodejs, without users. |
|
Ok, different problem. This PR is only associated with in-browser support. You can add another issue for the node stuff and we can see about adding support. Right now the adal node client is pretty basic so I am sure can be improved. |
|
I see. Thanks! :) |
Category
Related Issues
none
What's in this Pull Request?
Adds support for adal auth (AdalClient in .@pnp/common), Microsoft teams support (basic), adal client article, small fixes for tooling and banner.