Skip to content

Adding support for Adal auth, Microsoft Teams support, fixes#32

Merged
patrick-rodgers merged 5 commits intopnp:devfrom
patrick-rodgers:dev
Mar 9, 2018
Merged

Adding support for Adal auth, Microsoft Teams support, fixes#32
patrick-rodgers merged 5 commits intopnp:devfrom
patrick-rodgers:dev

Conversation

@patrick-rodgers
Copy link
Copy Markdown
Member

Category

  • Bug fix?
  • New feature?
  • New sample?
  • Documentation update?

Related Issues

none

What's in this Pull Request?

Adds support for adal auth (AdalClient in .@pnp/common), Microsoft teams support (basic), adal client article, small fixes for tooling and banner.

@patrick-rodgers patrick-rodgers added this to the 1.0.4 milestone Mar 8, 2018
@patrick-rodgers
Copy link
Copy Markdown
Member Author

@koltyakov have a quick look at this when you get a chance, please. Adds adal support and teams are the big things. New doc here.

Copy link
Copy Markdown
Member

@koltyakov koltyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Can't wait trying it on a project.

@eirikb
Copy link
Copy Markdown
Contributor

eirikb commented Mar 9, 2018

Isn't adal-angular a bit related to Angular? - Considering this fix does import * from 'angular-adal'.
Also, will this add SharePoint ADAL support (unless I'm mistaken, that still require SSL key)?

@patrick-rodgers
Copy link
Copy Markdown
Member Author

@eirikb - that is the package they published. Ideally it wouldn't be named that and would just have the core adal stuff, but that is the official adaljs package that is available. I am not sure what you mean by SPO requires keys? The below works for an app id registered with SPO permissions.

sp.setup({
    sp: {
        fetchClientFactory: () => {
            return new AdalClient(
                "ac68ea8f-79gc-47a7-a292-158c97331c66",
                "{tenant}.onmicrosoft.com",
                "https://{tenant}.sharepoint.com/_forms/spfxsinglesignon.aspx");
        },
    },
});

const r = await sp.web.get();

console.log(r);

@patrick-rodgers patrick-rodgers merged commit 133a692 into pnp:dev Mar 9, 2018
@eirikb
Copy link
Copy Markdown
Contributor

eirikb commented Mar 9, 2018

@patrick-rodgers is that for adal and user login? I'm thinking about from nodejs, without users.

@patrick-rodgers
Copy link
Copy Markdown
Member Author

Ok, different problem. This PR is only associated with in-browser support. You can add another issue for the node stuff and we can see about adding support. Right now the adal node client is pretty basic so I am sure can be improved.

@eirikb
Copy link
Copy Markdown
Contributor

eirikb commented Mar 9, 2018

I see. Thanks! :)
I think this issue will help a lot in general, as the support is probably a lot about ensuring that the headers will correctly follow the library methods around, which will help nodejs ADAL support a lot.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants