Add Permissions sections to entra user commands#7155
Merged
milanholemans merged 2 commits intopnp:mainfrom Mar 7, 2026
Merged
Conversation
AlejandroGispert
force-pushed
the
docs/entra-user-permissions
branch
from
9edbedc to
1de53b9
Compare
Contributor
Author
|
Hi @MartinM85, this is ready for review when you have time. |
Contributor
|
Thanks, we'll try to review it ASAP. |
There was a problem hiding this comment.
Pull request overview
Adds the required Permissions sections to the entra user command documentation to align with the repo’s documentation standards (per #6952), and updates contributor attribution.
Changes:
- Added a new Permissions section (placed before Examples) to the docs for
entra user add/get/hibp/list/remove/set, documenting minimal delegated and application permissions (or no Graph permissions for HIBP). - Updated docs to use Docusaurus
<Tabs>/<TabItem>where needed for delegated vs application permission presentation. - Added the contributor to
package.jsonand the docs team page.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Adds the contributor to the package metadata contributors list. |
| docs/docs/cmd/entra/user/user-add.mdx | Adds Permissions section for entra user add (delegated/app). |
| docs/docs/cmd/entra/user/user-get.mdx | Adds Permissions section for entra user get (delegated/app). |
| docs/docs/cmd/entra/user/user-hibp.mdx | Adds Permissions section clarifying HIBP uses no Microsoft Graph permissions. |
| docs/docs/cmd/entra/user/user-list.mdx | Adds Permissions section for entra user list (delegated/app). |
| docs/docs/cmd/entra/user/user-remove.mdx | Adds Permissions section for entra user remove (delegated/app). |
| docs/docs/cmd/entra/user/user-set.mdx | Adds Permissions section for entra user set (delegated/app). |
| docs/docs/about/team.mdx | Adds the contributor to the public team/contributors list in docs. |
milanholemans
requested changes
Mar 4, 2026
Contributor
milanholemans
left a comment
milanholemans
left a comment
There was a problem hiding this comment.
Nice work @AlejandroGispert, I think we should make a few changes before we merge it. Could you have a look at them, please? Also, check the feedback from Copilot.
AlejandroGispert
force-pushed
the
docs/entra-user-permissions
branch
2 times, most recently
from
0a9c2aa to
4881db8
Compare
Updates team member list by adding Alejandro Gispert alphabetically Corrects capitalization of "Global administrator" Removes redundant information about user retrieval methods in user-get documentation for clarity Removes redundant tab structure in user-hibp documentation for improved clarity Clarifies permissions section in user-hibp documentation Enhances table formatting
AlejandroGispert
force-pushed
the
docs/entra-user-permissions
branch
from
4881db8 to
179d2d9
Compare
Contributor
Author
|
Hi @milanholemans, I have implemented the modifications you suggested. Please take another look when you have a chance. |
Contributor
|
@AlejandroGispert nice! When ready, you can mark the PR as ready for review. |
Contributor
Author
|
@milanholemans done |
milanholemans
requested changes
Mar 5, 2026
Contributor
milanholemans
left a comment
milanholemans
left a comment
There was a problem hiding this comment.
Almost there @AlejandroGispert, let's do some final changes.
…ical order. Enhances documentation for the user-add command by moving and clarifying the permissions requirements.
Contributor
Author
|
Hi @milanholemans it should be correct now |
milanholemans
approved these changes
Mar 7, 2026
Contributor
milanholemans
left a comment
milanholemans
left a comment
There was a problem hiding this comment.
Nothing more to add!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Author: Alejandro Gispert
Third-time contributor to cli-microsoft365
## Summary
Closes #6952
Adds Permissions sections to all six
entra usercommands (add, get, hibp, list, remove, set) per #6952. Documents the minimal delegated and application permissions required to run each command.Commands updated
entra user addentra user getentra user listentra user removeentra user setentra user hibpConventions
entra user hibpdocumented as using Have I Been Pwned API (no Graph permissions)Permission rationale
Dev Proxy reports
User.ReadBasic.Allas minimal for basicget/listusage. We documentedUser.Read.Allinstead to align with the writing-the-docs requirement that permissions support any combination of options.User.ReadBasic.Allcan fail for--withManagerand custom--properties;User.Read.Allcovers all documented scenarios.Additional changes