Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses the broken Asciinema player rendering in the Docusaurus docs by removing the dependency on the corsproxy.io proxy (which now requires a paid plan), allowing the docs site to load .cast recordings directly again.
Changes:
- Removed
corsproxy.ioURL proxying for Asciinema cast sources. - Updated the player initialization to use the original
srcvalue directly. - Adjusted the React effect dependency list accordingly.
MartinM85
approved these changes
Feb 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7118
Fixed the Asciinema player for the time being. We can't leave the broken component on our docs.