Fixes unrecognized key error when using aliases. Closes #7064#7069
Merged
milanholemans merged 1 commit intopnp:mainfrom Dec 16, 2025
Merged
Fixes unrecognized key error when using aliases. Closes #7064#7069milanholemans merged 1 commit intopnp:mainfrom
milanholemans merged 1 commit intopnp:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the zod schema validation for SPE container commands where optional parameters with aliases were not being recognized correctly. The issue was caused by calling .optional() outside of zod.alias() instead of inside the type definition.
- Fixed the placement of
.optional()to be inside the type parameter ofzod.alias()calls - Applied the fix to three optional aliased parameters across two command files
- Makes the code consistent with the established pattern used throughout the codebase
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/m365/spe/commands/container/container-remove.ts | Fixed id and name optional aliased parameters by moving .optional() inside the type definition |
| src/m365/spe/commands/container/container-add.ts | Fixed description optional aliased parameter by moving .optional() inside the type definition |
Contributor
|
Thanks, we'll review it soon! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7064