New command: spe container recyclebinitem remove. Closes #6734#7065
New command: spe container recyclebinitem remove. Closes #6734#7065
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a new command spe container recyclebinitem remove that permanently removes a deleted container from the recycle bin. The implementation follows the established patterns from similar commands like container-recyclebinitem-restore and container-remove, providing consistent options for identifying containers by ID or name, with support for container type identification.
Key changes:
- New command implementation with confirmation prompt and force flag support
- Comprehensive test coverage with 259 lines of tests covering all scenarios
- Documentation page with usage examples and permission details
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/m365/spe/commands/container/container-recyclebinitem-remove.ts | New command implementation that permanently deletes containers from the recycle bin using DELETE request to the Graph API |
| src/m365/spe/commands/container/container-recyclebinitem-remove.spec.ts | Comprehensive test suite covering validation, confirmation prompts, ID/name-based removal, error handling, and multiple result scenarios |
| src/m365/spe/commands.ts | Command registration adding the new CONTAINER_RECYCLEBINITEM_REMOVE constant |
| docs/src/config/sidebars.ts | Sidebar navigation update to include the new command documentation |
| docs/docs/cmd/spe/container/container-recyclebinitem-remove.mdx | Reference documentation with options, permissions, examples, and usage instructions |
Saurabh7019
force-pushed
the
issue-6734
branch
from
b1cf957 to
a375d2e
Compare
|
Thanks, we'll try to review it soon! |
|
@Saurabh7019 Could you please rebase with main? We recently migrated Zod to v4, just to make sure everything will work. |
Saurabh7019
force-pushed
the
issue-6734
branch
from
a375d2e to
548ac16
Compare
Done! |
MartinM85
left a comment
MartinM85
left a comment
There was a problem hiding this comment.
Great work @Saurabh7019 🚀
I have a couple of small comments, nothing major.
Saurabh7019
force-pushed
the
issue-6734
branch
from
8d2800c to
7d807f3
Compare
MartinM85
left a comment
MartinM85
left a comment
There was a problem hiding this comment.
Approved. I will merge it later.
Thank you for the contribution @Saurabh7019 🚀
Closes #6734