spo folder copy#706
Closed
simonagren wants to merge 5 commits intopnp:devfrom
Closed
Conversation
Member
|
Thank you! I'll review it shortly |
waldekmastykarz
requested changes
Dec 15, 2018
Member
waldekmastykarz
left a comment
waldekmastykarz
left a comment
There was a problem hiding this comment.
When trying to use the command, I'm getting a File not found error.
Repro:
spo folder copy -u https://contoso.sharepoint.com/sites/marketing -s Shared%20Documents/Folder11 -t /sites/salesIt seems that the command generated invalid URL in the CreateCopyJobs payload:
CreateCopyJobs request...
body : {"exportObjectUris":["https://contoso.sharepoint.com/sites/Shared%20Documents/Folder11"],"destinationUri":"https://contoso.sharepoint.com/sites/sales","options":{"AllowSchemaMismatch":false,"IgnoreVersionHistory":true}}
headers: {"authorization":"Bearer eyJ0eXAiOiJKV1QiLCJhbGc...","accept":"application/json;odata=nometadata","User-Agent":"NONISV|SharePointPnP|Office365CLI/1.11.0"}
json : true
url : https://contoso.sharepoint.com/sites/marketing/_api/site/CreateCopyJobs
I also tried running
spo folder copy -u https://contoso.sharepoint.com/sites/marketing -s /Shared%20Documents/Folder11 -t /sites/salesand
spo folder copy -u https://contoso.sharepoint.com/sites/marketing -s "Shared Documents/Folder11" -t /sites/salesBut in all cases I'm getting the same error
waldekmastykarz
approved these changes
Dec 30, 2018
Member
waldekmastykarz
left a comment
waldekmastykarz
left a comment
There was a problem hiding this comment.
Nicely done with a few issues I've fixed when merging the PR
| webUrl: string; | ||
| sourceUrl: string; | ||
| targetUrl: string; | ||
| allowSchemaMismatch: boolean; |
Member
There was a problem hiding this comment.
allowSchemaMismatch should be optional
| ``` | ||
|
|
||
| Copies folder to a document library in another site collection. Allow for schema mismatch | ||
| ```sh |
Member
There was a problem hiding this comment.
There should be an empty line between text and a code block. Additionally, the code block shouldn't be indented.
| `-u, --webUrl <webUrl>`|The URL of the site where the folder is located | ||
| `-s, --sourceUrl <sourceUrl>`|Site-relative URL of the folder to copy | ||
| `-t, --targetUrl <targetUrl>`|Server-relative URL where to copy the folder | ||
| `--allowSchemaMismatch`|Ignores any missing fields in the target destination and copies the folder anyway |
Member
There was a problem hiding this comment.
Doesn't match the option description in the command
| `-u, --webUrl <webUrl>`|The URL of the site where the folder is located | ||
| `-s, --sourceUrl <sourceUrl>`|Site-relative URL of the folder to copy | ||
| `-t, --targetUrl <targetUrl>`|Server-relative URL where to copy the folder | ||
| `--allowSchemaMismatch`|Ignores any missing fields in the target destination and copies the folder anyway |
Member
There was a problem hiding this comment.
target and destination are the same thing. No need to mention them both in one sentence
Member
|
Merged manually. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made a few changes to match the changes made in
spo file moveandspo folder move