New command: spo brandcenter settings list. Closes #6653#7058
Merged
milanholemans merged 3 commits intopnp:mainfrom Feb 23, 2026
Merged
New command: spo brandcenter settings list. Closes #6653#7058milanholemans merged 3 commits intopnp:mainfrom
milanholemans merged 3 commits intopnp:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request introduces a new command spo brandcenter settings list to retrieve SharePoint Brand Center configuration settings. The implementation follows the established patterns for SPO commands that accept only global options, using the Zod schema validation approach.
- Adds a new SPO command to list Brand Center configuration
- Includes comprehensive test coverage with schema validation tests
- Provides complete documentation with examples and response formats in multiple output types
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/m365/spo/commands/brandcenter/brandcenter-settings-list.ts | Main command implementation that fetches Brand Center configuration via SharePoint REST API |
| src/m365/spo/commands/brandcenter/brandcenter-settings-list.spec.ts | Comprehensive test suite covering validation, success scenarios, and error handling |
| src/m365/spo/commands.ts | Registers the new BRANDCENTER_SETTINGS_LIST command constant |
| docs/src/config/sidebars.ts | Adds the new command to the documentation sidebar under brandcenter category |
| docs/docs/cmd/spo/brandcenter/brandcenter-settings-list.mdx | Complete documentation including usage, permissions, examples, and response formats |
| .devproxy/api-specs/sharepoint.yaml | Adds API specification for the Brand Center Configuration endpoint with security requirements |
Saurabh7019
force-pushed
the
issue-6653
branch
from
c3e8745 to
856edfe
Compare
Contributor
|
Thanks! We'll try to review it soon. |
milanholemans
requested changes
Jan 15, 2026
Contributor
milanholemans
left a comment
milanholemans
left a comment
There was a problem hiding this comment.
Nice work! Let's do a couple of changes before we merge it.
Saurabh7019
force-pushed
the
issue-6653
branch
3 times, most recently
from
9e5cf9f to
e117083
Compare
milanholemans
force-pushed
the
issue-6653
branch
from
e117083 to
fe2317a
Compare
milanholemans
approved these changes
Feb 23, 2026
Contributor
milanholemans
left a comment
milanholemans
left a comment
There was a problem hiding this comment.
Awesome work! Made a few small adjustments while merging.
| }); | ||
|
|
||
| await command.action(logger, { options: {} }); | ||
| assert.strictEqual(getStub.firstCall.args[0].url, 'https://contoso.sharepoint.com/_api/Brandcenter/Configuration'); |
Contributor
There was a problem hiding this comment.
This is actually already tested in the stub defined above. Instead, we should just check if the stub was executed once.
| }); | ||
|
|
||
| await command.action(logger, { options: { verbose: true } }); | ||
| assert(loggerLogSpy.calledWith(successResponse)); |
Contributor
There was a problem hiding this comment.
Let's be a bit more strict here:
Suggested change
| assert(loggerLogSpy.calledWith(successResponse)); | |
| assert(loggerLogSpy.calledOnceWithExactly(successResponse)); |
| ```json | ||
| { | ||
| "BrandColorsListId": "00000000-0000-0000-0000-000000000000", | ||
| "BrandColorsListUrl": null, |
Contributor
There was a problem hiding this comment.
Enhanced the response with this property.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6653