Spo file copy updated#705
Closed
simonagren wants to merge 6 commits intopnp:devfrom
Closed
Conversation
Member
|
Thank you! I'll review it shortly |
waldekmastykarz
requested changes
Dec 15, 2018
Member
waldekmastykarz
left a comment
waldekmastykarz
left a comment
There was a problem hiding this comment.
When trying to use the command, I'm getting a File not found error.
Repro:
spo file copy -u https://contoso.sharepoint.com/sites/marketing -s /Shared%20Documents/BrandingElements.png -t /sites/sales/Shared%20DocumentsIt seems that the command generated invalid URL in the CreateCopyJobs payload:
CreateCopyJobs request...
body : {"exportObjectUris":["https://contoso.sharepoint.com/sites/Shared%20Documents/BrandingElements.png"],"destinationUri":"https://contoso.sharepoint.com/sites/sales/Shared%20Documents","options":{"AllowSchemaMismatch":false,"IgnoreVersionHistory":true}}
headers: {"authorization":"Bearer eyJ0eXAiOiJKV1QiLCJhbGc...","accept":"application/json;odata=nometadata","User-Agent":"NONISV|SharePointPnP|Office365CLI/1.11.0"}
json : true
url : https://contoso.sharepoint.com/sites/marketing/_api/site/CreateCopyJobs
I also tried running
spo file copy -u https://contoso.sharepoint.com/sites/marketing -s Shared%20Documents/BrandingElements.png -t /sites/sales/Shared%20Documentsand
spo file copy -u https://contoso.sharepoint.com/sites/marketing -s "/Shared Documents/BrandingElements.png" -t /sites/sales/Shared%20DocumentsBut in all cases I'm getting the same error
waldekmastykarz
approved these changes
Dec 30, 2018
Member
waldekmastykarz
left a comment
waldekmastykarz
left a comment
There was a problem hiding this comment.
Nicely done with a few things I've fixed when merging the PR
| sourceUrl: string; | ||
| targetUrl: string; | ||
| deleteIfAlreadyExists?: boolean; | ||
| allowSchemaMismatch: boolean; |
Member
There was a problem hiding this comment.
allowSchemaMismatch should be optional
| `-t, --targetUrl <targetUrl>`|Server-relative URL where to copy the file | ||
| `--deleteIfAlreadyExists`|If a file already exists at the targetUrl, it will be moved to the recycle bin. If omitted, the copy operation will be canceled if the file already exists at the targetUrl location | ||
| `--deleteIfAlreadyExists`|If a file already exists at the targetUrl, it will be moved to the recycle bin. If omitted, the copy | ||
| operation will be canceled if the file already exists at the targetUrl location |
Member
There was a problem hiding this comment.
Breaking lines in a table in MD breaks formatting creating a new row. Instead, the whole description should be in one line
| ``` | ||
|
|
||
| Copy file to a document library in another site collection. Allow for schema mismatch | ||
| ```sh |
Member
There was a problem hiding this comment.
There should be an empty line between the text and code block. Additionally, the code block shouldn't be indented
| spo file copy --webUrl https://contoso.sharepoint.com/sites/test1 --sourceUrl /Shared%20Documents/sp1.pdf --targetUrl /sites/test2/Shared%20Documents/ --deleteIfAlreadyExists | ||
| ``` | ||
|
|
||
| Copy file to a document library in another site collection. Allow for schema mismatch |
Member
There was a problem hiding this comment.
This content is different from the help included in command. Both should be the same
Member
|
Merged manually. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made a few changes to match the changes made in
spo file moveandspo folder move