Skip to content

Migrate 'entra multitenant add' to Zod. Closes #6906#7035

Merged
martinlingstuyl merged 3 commits intopnp:mainfrom
MartinM85:feature/6906-migrate-entra-multitenant-add-zod
Nov 3, 2025
Merged

Migrate 'entra multitenant add' to Zod. Closes #6906#7035
martinlingstuyl merged 3 commits intopnp:mainfrom
MartinM85:feature/6906-migrate-entra-multitenant-add-zod

Conversation

@MartinM85
Copy link
Copy Markdown
Contributor

Closes #6906

@martinlingstuyl martinlingstuyl added the hacktoberfest-accepted Accept for hacktoberfest, will merge later label Oct 29, 2025
Copy link
Copy Markdown
Contributor

@martinlingstuyl martinlingstuyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @MartinM85, great work! I've made a couple of comments. Could you look at them and fix them?

Comment thread src/m365/entra/commands/multitenant/multitenant-add.spec.ts Outdated
Comment thread src/m365/entra/commands/multitenant/multitenant-add.ts Outdated
@martinlingstuyl martinlingstuyl self-assigned this Oct 29, 2025
@martinlingstuyl martinlingstuyl marked this pull request as draft October 29, 2025 19:34
@MartinM85 MartinM85 marked this pull request as ready for review October 30, 2025 07:41
Comment thread src/m365/entra/commands/multitenant/multitenant-add.spec.ts Outdated
Comment thread src/m365/entra/commands/multitenant/multitenant-add.spec.ts Outdated
@martinlingstuyl martinlingstuyl marked this pull request as draft November 3, 2025 10:36
@MartinM85 MartinM85 marked this pull request as ready for review November 3, 2025 10:49
Copy link
Copy Markdown
Contributor

@martinlingstuyl martinlingstuyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@martinlingstuyl martinlingstuyl merged commit b46e017 into pnp:main Nov 3, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest-accepted Accept for hacktoberfest, will merge later pr-merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate 'entra multitenant add' to Zod

2 participants