Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR implements a new SharePoint Online command spo site accessrequest setting set that allows users to configure access request settings for a specific site. The command supports disabling access requests, routing them to the site owner group, or routing them to a specific email address, with optional custom messaging.
Key Changes
- Adds new command to configure SharePoint site access request settings
- Implements comprehensive validation for mutually exclusive options
- Includes extensive test coverage with 100% code coverage
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
src/m365/spo/commands/site/site-accessrequest-setting-set.ts |
Main command implementation with validation and API calls to SharePoint REST endpoints |
src/m365/spo/commands/site/site-accessrequest-setting-set.spec.ts |
Comprehensive test suite covering validation scenarios and execution paths |
src/m365/spo/commands.ts |
Adds command constant for registration |
docs/src/config/sidebars.ts |
Updates documentation sidebar navigation |
docs/docs/cmd/spo/site/site-accessrequest-setting-set.mdx |
Command documentation with usage examples and permissions |
.devproxy/api-specs/sharepoint.yaml |
Adds API specifications for the SharePoint REST endpoints used |
martinlingstuyl
added
the
hacktoberfest-accepted
Contributor
|
@MathijsVerbeeck, could you align this PR with the latest version of Zod? This will improve the review process. |
MathijsVerbeeck
force-pushed
the
add-spo-site-accessrequest-setting-set
branch
from
4546314 to
e679b2b
Compare
MartinM85
approved these changes
Mar 18, 2026
Contributor
MartinM85
left a comment
MartinM85
left a comment
There was a problem hiding this comment.
Great work @MathijsVerbeeck. No comments from my side.
Approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6267