New command: spo site alert remove. Closes #6863#6997
Merged
milanholemans merged 3 commits intopnp:mainfrom Oct 25, 2025
Merged
New command: spo site alert remove. Closes #6863#6997milanholemans merged 3 commits intopnp:mainfrom
milanholemans merged 3 commits intopnp:mainfrom
Conversation
Contributor
|
Thanks @Saurabh7019! We'll try to review it ASAP. |
milanholemans
requested changes
Oct 12, 2025
Contributor
milanholemans
left a comment
milanholemans
left a comment
There was a problem hiding this comment.
The command is nearly perfect! When the comments below are processed, it looks good to go.
Saurabh7019
force-pushed
the
issue-6863
branch
from
bc2ca6a to
10c9e24
Compare
milanholemans
approved these changes
Oct 25, 2025
Contributor
milanholemans
left a comment
milanholemans
left a comment
There was a problem hiding this comment.
Awesome, PR is good to go with some minor tweaks!
| const requestOptions: CliRequestOptions = { | ||
| url: `${args.options.webUrl}/_api/web/Alerts/DeleteAlert('${formatting.encodeQueryParameter(args.options.id)}')`, | ||
| headers: { | ||
| accept: 'application/json;' |
Contributor
There was a problem hiding this comment.
Suggested change
| accept: 'application/json;' | |
| accept: 'application/json;odata=nometadata' |
| }); | ||
|
|
||
| it('fails validation if webUrl is not a valid URL', async () => { | ||
| const actual = commandOptionsSchema.safeParse({ webUrl: 'foo' }); |
Contributor
There was a problem hiding this comment.
Let's also add a valid ID since this property is required.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6863