Upgrades eslint to v9#6880
Merged
martinlingstuyl merged 1 commit intopnp:mainfrom Oct 8, 2025
Merged
Conversation
milanholemans
force-pushed
the
tslint-upgrade
branch
from
65c99bf to
1bfbcb7
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades ESLint from v8 to v9, which required extensive code changes to comply with newly activated rules. The upgrade modernizes the linting configuration by migrating from the legacy .eslintrc.cjs format to the new flat config system in eslint.config.mjs.
- Migrate to ESLint v9 flat configuration system
- Fix violations from newly activated ESLint rules across the codebase
- Update TypeScript and Mocha ESLint plugins to compatible versions
Reviewed Changes
Copilot reviewed 161 out of 163 changed files in this pull request and generated 8 comments.
| File | Description |
|---|---|
| package.json | Updated ESLint and related dependencies to v9 compatible versions |
| eslint.config.mjs | New flat configuration replacing the old .eslintrc.cjs format |
| .eslintrc.cjs | Removed legacy ESLint configuration file |
| Various TS files | Fixed ESLint rule violations including function return types, unused catch variables, regex escaping, and code formatting |
Files not reviewed (1)
- npm-shrinkwrap.json: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
milanholemans
force-pushed
the
tslint-upgrade
branch
from
1bfbcb7 to
9ccaf1a
Compare
martinlingstuyl
force-pushed
the
tslint-upgrade
branch
3 times, most recently
from
33d51b8 to
ccc5180
Compare
martinlingstuyl
requested changes
Oct 8, 2025
Contributor
martinlingstuyl
left a comment
martinlingstuyl
left a comment
There was a problem hiding this comment.
Great work Milan, a couple of small comments...
milanholemans
force-pushed
the
tslint-upgrade
branch
from
ccc5180 to
b7635d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6350
After upgrading to the latest Eslint version, a lot of extra rules were activated, which all made sense. This means I had to make quite a few changes to files violating these rules.