New command: teams callrecord get. Closes #6738#6851
Merged
milanholemans merged 8 commits intopnp:mainfrom Feb 23, 2026
Merged
Conversation
Contributor
|
Thanks Martin, we'll try to review it soon. |
Contributor
|
@MartinM85, could you align this PR with the latest version of Zod? This will improve the review process. |
MartinM85
force-pushed
the
feature/6738-teams-callrecord-get
branch
from
19876fe to
6d1b8be
Compare
Contributor
Author
Rebased with the main. |
There was a problem hiding this comment.
Pull request overview
This pull request adds a new command teams callrecord get to retrieve detailed information about a specific Microsoft Teams call record using the Microsoft Graph API. The implementation follows the established codebase patterns for application-only commands and includes comprehensive test coverage and documentation.
Changes:
- New command implementation for retrieving Teams call records by ID with expanded session and participant data
- Test suite with validation tests, success scenarios, and error handling
- Documentation page with usage examples and important remarks about the 30-day retention limit
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/m365/teams/commands/callrecord/callrecord-get.ts | Implements the new command that retrieves call records with two API calls to expand both sessions/segments and participants_v2 |
| src/m365/teams/commands/callrecord/callrecord-get.spec.ts | Comprehensive test suite covering validation, successful retrieval, and error handling scenarios |
| src/m365/teams/commands.ts | Adds the new CALLRECORD_GET command constant to the commands registry |
| docs/src/config/sidebars.ts | Adds the new command to the documentation sidebar navigation |
| docs/docs/cmd/teams/callrecord/callrecord-get.mdx | Complete documentation page with usage, options, examples, and response formats |
| npm-shrinkwrap.json | Contains unrelated changes adding "peer": true flags to several packages |
Files not reviewed (1)
- npm-shrinkwrap.json: Language not supported
milanholemans
requested changes
Feb 14, 2026
Contributor
milanholemans
left a comment
milanholemans
left a comment
There was a problem hiding this comment.
Nice work Martin! During review I had a few remarks we should take a look at first.
MartinM85
force-pushed
the
feature/6738-teams-callrecord-get
branch
from
6d1b8be to
e0124f8
Compare
milanholemans
approved these changes
Feb 23, 2026
|
|
||
| it('handles random API error', async () => { | ||
| const errorMessage = 'Could not find the requested call record. Records about calls or online meetings that started more than 30 days ago are not available.'; | ||
| sinon.stub(request, 'get').rejects(new Error(errorMessage)); |
Contributor
There was a problem hiding this comment.
The structure of this error does not match the structure that the Graph API throws. Usually, the error message is wrapped into an error object like:
{
"error": {
"message": "Error occurred."
}
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6738