Extends spo SPFx commands commands with support for adding description option. Closes #6706#6767
Conversation
|
Thanks @SmitaNachan! We'll have a look at it ASAP! |
milanholemans
left a comment
milanholemans
left a comment
There was a problem hiding this comment.
Thanks for extending our code with this feature. Could you have a look at the comments I made, please? I believe we have to fix a few things before we can continue.
|
Hi @SmitaNachan, just checking if you found some time to check the feedback on this PR. |
milanholemans
left a comment
milanholemans
left a comment
There was a problem hiding this comment.
Hi @SmitaNachan, I found a few more things we should adjust. Could you take a look at it, please?
There was a problem hiding this comment.
Pull Request Overview
This PR extends the SharePoint SPFx command set and application customizer commands with support for adding a description option, addressing issue #6706.
- Adds optional
descriptionparameter to four SPFx commands (commandset add/set and applicationcustomizer add/set) - Updates command validation logic to include the new description option
- Adds comprehensive test coverage for the new description functionality
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| commandset-set.ts | Adds description option and includes it in request body and validation logic |
| commandset-set.spec.ts | Updates tests to include description parameter and validates request body structure |
| commandset-add.ts | Adds description option to telemetry and request body |
| commandset-add.spec.ts | Adds test coverage for description parameter in request body |
| applicationcustomizer-set.ts | Adds description option and includes it in request body and validation logic |
| applicationcustomizer-set.spec.ts | Updates tests to validate description parameter in request body |
| applicationcustomizer-add.ts | Adds description option to telemetry and request body |
| applicationcustomizer-add.spec.ts | Updates test data and validates description parameter in request body |
| Documentation files | Updates command documentation to include the new description option |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Hi @SmitaNachan, have you found some time yet to process the feedback on this PR? |
|
Hi @milanholemans |
SmitaNachan
force-pushed
the
issue-6706
branch
from
dc686e6 to
10ae350
Compare
milanholemans
left a comment
milanholemans
left a comment
There was a problem hiding this comment.
Hi @SmitaNachan, nearly there, let's make sure that it's possible to pass an empty string to clear the description.
If you have any questions, feel free to reach out to me.
milanholemans
left a comment
milanholemans
left a comment
There was a problem hiding this comment.
Looks good to go with a few adjustments.
There was a problem hiding this comment.
Let's add an additional test to validate if an empty description can be passed.
There was a problem hiding this comment.
Let's add a test for an empty description.
Extends spo SPFx commands commands with support for adding description option. Closes #6706