Skip to content

Adds command 'cli app reconsent'#6680

Merged
martinlingstuyl merged 1 commit intopnp:mainfrom
milanholemans:cli-app-reconsent
May 22, 2025
Merged

Adds command 'cli app reconsent'#6680
martinlingstuyl merged 1 commit intopnp:mainfrom
milanholemans:cli-app-reconsent

Conversation

@milanholemans
Copy link
Copy Markdown
Contributor

Closes #6657

@milanholemans milanholemans requested a review from Copilot April 8, 2025 17:49
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

Files not reviewed (1)
  • docs/docs/cmd/cli/app/app-reconsent.mdx: Language not supported
Comments suppressed due to low confidence (1)

src/m365/cli/commands/app/app-reconsent.ts:118

  • Ensure that casting the data object to Application fulfills the API requirements; if only updating requiredResourceAccess, consider using a partial type or constructing a full Application object.
data: { requiredResourceAccess: appScopes } as Application

Comment thread src/m365/cli/commands/app/app-reconsent.ts Outdated
@martinlingstuyl martinlingstuyl self-assigned this May 21, 2025
Copy link
Copy Markdown
Contributor

@martinlingstuyl martinlingstuyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two comments, aside from that it looks like a solid PR and it works nicely...

Comment thread src/m365/cli/commands/app/app-reconsent.ts Outdated
Comment thread src/m365/cli/commands/app/app-reconsent.ts Outdated
@martinlingstuyl martinlingstuyl marked this pull request as draft May 21, 2025 20:12
@milanholemans milanholemans marked this pull request as ready for review May 21, 2025 22:14
@martinlingstuyl martinlingstuyl merged commit bb3c2e6 into pnp:main May 22, 2025
9 checks passed
@milanholemans milanholemans deleted the cli-app-reconsent branch May 22, 2025 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New command: cli app reconsent

3 participants