Adds login using federated identity for GitHub actions. Closes #6610#6611
Closed
martinlingstuyl wants to merge 1 commit intopnp:mainfrom
Closed
Adds login using federated identity for GitHub actions. Closes #6610#6611martinlingstuyl wants to merge 1 commit intopnp:mainfrom
martinlingstuyl wants to merge 1 commit intopnp:mainfrom
Conversation
martinlingstuyl
force-pushed
the
feature/federated-identity-github
branch
from
4a1dc16 to
61f9eb7
Compare
martinlingstuyl
changed the title
milanholemans
requested changes
Mar 10, 2025
Contributor
milanholemans
left a comment
milanholemans
left a comment
There was a problem hiding this comment.
Nice stuff @martinlingstuyl, made a few tiny remarks.
martinlingstuyl
force-pushed
the
feature/federated-identity-github
branch
from
61f9eb7 to
33d0277
Compare
martinlingstuyl
force-pushed
the
feature/federated-identity-github
branch
from
33d0277 to
97f961d
Compare
milanholemans
approved these changes
Mar 16, 2025
Contributor
milanholemans
left a comment
milanholemans
left a comment
There was a problem hiding this comment.
Made a few tiny changes while merging, but overall it looked great and ready to ship!
Thanks for adding this feature to the CLI.
When the next release is out, we should not forget to add this functionality to the pnp/action-cli-login repo.
Contributor
|
Merged manually. Thank you for adding this awesome feature! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature/federated identity GitHub. Closes #6610