Conversation
|
Thank you, we'll try to review it ASAP! |
milanholemans
left a comment
milanholemans
left a comment
There was a problem hiding this comment.
Nice start, let's do a few enhancements before we continue.
|
I have done rebase to main and added the commit. Is it fine or do I need to resolve anything from my end. Please guide me |
|
@ktskumar seems like something went horribly wrong while rebasing with the latest main. Could you have a look at it, please? |
milanholemans
left a comment
milanholemans
left a comment
There was a problem hiding this comment.
Apart from a few comments, it looks good to go!
| sinon.stub(cli, 'promptForConfirmation').callsFake(async () => { | ||
| promptIssued = true; | ||
| return Promise.resolve(false); | ||
| //return Promise.resolve(false); |
There was a problem hiding this comment.
Let's remove comments
| sinon.stub(request, 'post').callsFake(async (opts) => { | ||
| requests.push(opts); | ||
| if (opts.url === `${webUrl}/_api/web/lists/GetByTitle('${listTitle}')/recycle`) { | ||
| return 'Correct URL'; |
There was a problem hiding this comment.
This API doesn't return any result. Let's also return nothing in our stub.
| requests.forEach(r => { | ||
| if (r.url === `${webUrl}/_api/web/lists/GetByTitle('${listTitle}')/recycle`) { | ||
| correctRequestIssued = true; | ||
| } | ||
| }); |
There was a problem hiding this comment.
Instead of doing this, let's use assert(postStub.calledOnce). This ensures that the request was called once and didn't throw an error.
|
Merged manually, thanks! |
2 participants
closes #6270
In this PR, i have added a recycle option to
spo list removecommand