Fixes casing and autocomplete for enums based on zod#6373
Fixes casing and autocomplete for enums based on zod#6373waldekmastykarz wants to merge 1 commit intopnp:mainfrom
Conversation
milanholemans
left a comment
There was a problem hiding this comment.
While this will work for existing enums like login uses, what about other enum commands?
I think we'll need something similar for all commands that use choices for instance:
cli-microsoft365/src/Command.ts
Lines 48 to 53 in 53b407a
I suggest that we migrate all string-based enums to native enums. This will help us make our code more robust. We'll no longer depend on magic strings, and instead will have full design-time support for typings and refactorings. |
|
ready to merge 🚀 |
|
Merged manually. Thank you for your awesome contribution 👏. |

This PR introduces two changes:
deviceCodeinstead ofDeviceCode)