Skip to content

Enhance entra m365group user set by specifying multiple users. #6100

Closed
Saurabh7019 wants to merge 2 commits intopnp:mainfrom
Saurabh7019:issue-6059
Closed

Enhance entra m365group user set by specifying multiple users. #6100
Saurabh7019 wants to merge 2 commits intopnp:mainfrom
Saurabh7019:issue-6059

Conversation

@Saurabh7019
Copy link
Copy Markdown
Contributor

Closes #6059

Comment thread docs/docs/cmd/entra/m365group/m365group-user-set.mdx
Comment thread docs/docs/cmd/entra/m365group/m365group-user-set.mdx Outdated
Copy link
Copy Markdown
Contributor

@MathijsVerbeeck MathijsVerbeeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Saurabh7019. Thanks for this pull review. Code works great. Could you have a look at the comments I made?

Comment thread docs/docs/cmd/entra/m365group/m365group-user-set.mdx Outdated
Comment thread src/m365/entra/commands/m365group/m365group-user-set.ts
Comment thread src/m365/entra/commands/m365group/m365group-user-set.ts
Comment thread src/m365/entra/commands/m365group/m365group-user-set.ts Outdated
Comment thread src/m365/entra/commands/m365group/m365group-user-set.ts Outdated
Comment thread src/m365/entra/commands/m365group/m365group-user-set.ts Outdated
Comment thread src/m365/entra/commands/m365group/m365group-user-set.ts Outdated
Comment thread src/m365/entra/commands/m365group/m365group-user-set.ts Outdated
Comment thread src/m365/entra/commands/m365group/m365group-user-set.ts Outdated
@MathijsVerbeeck MathijsVerbeeck marked this pull request as draft August 7, 2024 11:52
@Saurabh7019 Saurabh7019 marked this pull request as ready for review August 9, 2024 07:52
@Saurabh7019
Copy link
Copy Markdown
Contributor Author

Hi @Saurabh7019. Thanks for this pull review. Code works great. Could you have a look at the comments I made?

Hi @MathijsVerbeeck , I have made the changes you suggested. Thank you for taking the time to review this and some of my other PRs. I really appreciate it!

@MathijsVerbeeck
Copy link
Copy Markdown
Contributor

PR merged succesfully. Thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enhance entra m365group user set by specifying multiple users

2 participants