Enhance entra m365group user add by specifying multiple users. Closes…#6090
Closed
Saurabh7019 wants to merge 2 commits intopnp:mainfrom
Closed
Enhance entra m365group user add by specifying multiple users. Closes…#6090Saurabh7019 wants to merge 2 commits intopnp:mainfrom
Saurabh7019 wants to merge 2 commits intopnp:mainfrom
Conversation
Contributor
|
Thanks, we'll try to review it ASAP! |
MathijsVerbeeck
requested changes
Aug 6, 2024
Contributor
MathijsVerbeeck
left a comment
MathijsVerbeeck
left a comment
There was a problem hiding this comment.
Hi @Saurabh7019. Thanks for this PR. Command seems to be working great. I have made a few remarks. Could you please have a look at them?
MathijsVerbeeck
approved these changes
Aug 8, 2024
Contributor
MathijsVerbeeck
left a comment
MathijsVerbeeck
left a comment
There was a problem hiding this comment.
Really good job Saurabh. I will merge this soon. Thanks for the addition
Contributor
Author
Thank you @MathijsVerbeeck , I made one more minor change to make the role validation to be case insensitive. |
Contributor
|
PR merged succesfully. Thanks for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6060