Adds command 'entra group user add'.#5759
Closed
milanholemans wants to merge 1 commit intopnp:mainfrom
Closed
Conversation
This was referenced Jan 9, 2024
waldekmastykarz
requested changes
Jan 20, 2024
Member
waldekmastykarz
left a comment
waldekmastykarz
left a comment
There was a problem hiding this comment.
Very nice! Awesome use of batching! Let's do a few adjustments before we merge it
milanholemans
force-pushed
the
entra-group-user-add
branch
from
12fde76 to
ed9824d
Compare
milanholemans
force-pushed
the
entra-group-user-add
branch
from
ed9824d to
9c0133e
Compare
milanholemans
force-pushed
the
entra-group-user-add
branch
from
9c0133e to
cb0ec92
Compare
|
|
||
| if (args.options.ids) { | ||
| const ids = args.options.ids.split(',').map(i => i.trim()); | ||
| if (!validation.isValidGuidArray(ids)) { |
Member
There was a problem hiding this comment.
Let's update this in a separate issue so that we don't need to iterate through the array twice
Member
|
Merged manually. Thank you! 👏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5471