Adds "aad group user list" command. Closes #5469 by nanddeepn · Pull Request #5537 · pnp/cli-microsoft365

nanddeepn · 2023-10-02T02:16:04Z

Adds aad group user list command. Closes #5469

😍 Happy Hacktoberfest !

Jwaegebaert · 2023-10-02T07:46:56Z

Hey @nanddeepn, looks like the docs job is failing. Could you take a look at that?

nanddeepn · 2023-10-02T08:06:34Z

Hi @Jwaegebaert
Any guidance, how can I reproduce this locally?
May be this can help? https://pnp.github.io/cli-microsoft365/contribute/new-command/writing-the-docs/#running-docusaurus-locally

Jwaegebaert · 2023-10-02T08:28:15Z

Yes, indeed. By following the link you posted you should be able to reproduce it locally

nanddeepn · 2023-10-02T10:41:06Z

Hi @Jwaegebaert
I tried the instructions locally and the documentation seems to be working fine.

Anything else, I am missing here?

nanddeepn · 2023-10-02T17:08:27Z

docs job fails, when I add below to sidebars.js. Any suggestions please?

{
     type: 'doc',
     label: 'group user list',
     id: 'cmd/aad/group/group-user-list'
}

Jwaegebaert · 2023-10-03T15:38:38Z

@nanddeepn, we're looking into it. It seems to be more complex than we imagined. I'll keep you posted once we find something.

martinlingstuyl

Hi @nanddeepn, thanks for your contribution. I did a review and have some comments. I also have a point of open discussion I'm not yet sure about. I'll ping Milan about it.

martinlingstuyl · 2023-10-03T18:36:59Z

Hi @nanddeepn, I've discussed this internally, and it seems we've got an interesting confusion here. 'Owners and Members' are something else then 'Members and Guests', the userType property is an example of the last. MS graph returns user objects, and userType is simply a user property there.

It's the fault of the specs, so we'll be changing the specs. In its current state it's just not feasible and confusing.

We've seen that this code is a copy of m365group user list, so that command will need to change as well (later on)

You'll see it when the specs have been updated.

…ft365 into issue-5469

martinlingstuyl · 2023-10-04T14:44:32Z

He @nanddeepn, the specs have not yet been updated, 😂 you'll have to wait some more..

milanholemans · 2023-10-08T20:06:43Z

Hi @nanddeepn

We took a few days to look at the issue you are facing with Docusaurus.

In a nutshell:

We managed to get it working again by adding an extra config value: trailingSlash: false. This should be added in the Docusaurus config file here:

cli-microsoft365/docs/docusaurus.config.js

Lines 6 to 15 in 8b56e1d

    
           title: 'CLI for Microsoft 365', 
        
           titleDelimiter: '-', 
        
           tagline: 'Docs', 
        
           url: 'https://pnp.github.io', 
        
           baseUrl: '/cli-microsoft365/', 
        
           onBrokenLinks: 'throw', 
        
           onBrokenMarkdownLinks: 'throw', 
        
           favicon: 'img/favicon.ico', 
        
           organizationName: 'pnp', 
        
           projectName: 'cli-microsoft365',

Why does this make the pipeline work? We have no idea, to be honest. In fact, we even reached out to the mods/maintainers of Docusaurus, and even they have no idea what caused this issue and why the trailingSlash is fixing it.
As far as we know, this setting can't hurt us, so we'll take it as a solution. Could you add it to this PR?

Thanks!

martinlingstuyl

Hi @nanddeepn, let's look at some comments before we merge this...

martinlingstuyl

Hi @nanddeepn, I've got a few last round comments. We'll merge this as soon as possible afterwards.

martinlingstuyl

Looks fine with some last cosmetic changes

martinlingstuyl · 2023-10-24T20:14:08Z

+List all group users from a group specified by name. For each one return the display name, e-mail address, and memberof.
+
+```sh
+m365 aad group user list --groupDisplayName Developers --properties "displayName,mail,memberof/id"


Let's use manager/displayName as example.

Let's include an extra example with manager/*

martinlingstuyl · 2023-10-25T06:13:23Z

Merged manually, thanks 👏

aad group user list

22c8c82

Jwaegebaert added the hacktoberfest-accepted Accept for hacktoberfest, will merge later label Oct 2, 2023

docs change

16ffe37

Jwaegebaert removed the hacktoberfest-accepted Accept for hacktoberfest, will merge later label Oct 2, 2023

nanddeepn added 2 commits October 2, 2023 22:13

Update sidebars.js

d41eb5d

Update sidebars.js

071d264

martinlingstuyl requested changes Oct 3, 2023

View reviewed changes

Comment thread docs/docs/cmd/aad/group/group-user-list.mdx Outdated

Comment thread src/m365/aad/commands/group/group-user-list.spec.ts Outdated

Comment thread src/m365/aad/commands/group/group-user-list.ts Outdated

martinlingstuyl reviewed Oct 3, 2023

View reviewed changes

Comment thread src/m365/aad/commands/group/group-user-list.ts Outdated

martinlingstuyl self-assigned this Oct 3, 2023

martinlingstuyl marked this pull request as draft October 3, 2023 18:37

nanddeepn added 2 commits October 4, 2023 10:41

review comments

ee1b449

Merge branch 'issue-5469' of https://github.com/nanddeepn/cli-microso…

712b55e

…ft365 into issue-5469

nanddeepn marked this pull request as ready for review October 4, 2023 10:48

milanholemans marked this pull request as draft October 8, 2023 20:06

new specs changes

20c9beb

nanddeepn marked this pull request as ready for review October 11, 2023 11:49

martinlingstuyl requested changes Oct 12, 2023

View reviewed changes

martinlingstuyl marked this pull request as draft October 12, 2023 20:56

review comments

4fbb54d

nanddeepn marked this pull request as ready for review October 13, 2023 11:24

martinlingstuyl requested changes Oct 18, 2023

View reviewed changes

Comment thread src/m365/aad/commands/group/group-user-list.ts Outdated

Comment thread src/m365/aad/commands/group/group-user-list.ts Outdated

Comment thread src/m365/aad/commands/group/group-user-list.ts Outdated

martinlingstuyl marked this pull request as draft October 18, 2023 15:07

review comments

15c6b3f

nanddeepn marked this pull request as ready for review October 19, 2023 11:34

martinlingstuyl approved these changes Oct 25, 2023

View reviewed changes

martinlingstuyl added the pr-merged label Oct 25, 2023

martinlingstuyl closed this Oct 25, 2023

martinlingstuyl added the hacktoberfest-accepted Accept for hacktoberfest, will merge later label Oct 25, 2023

nanddeepn deleted the issue-5469 branch October 25, 2023 06:49

milanholemans mentioned this pull request Dec 30, 2023

Removes trailing slash config #5733

Closed

milanholemans mentioned this pull request Jan 7, 2024

Remove deprecated yammer commands #5764

Closed

2 tasks

Conversation

nanddeepn commented Oct 2, 2023

Uh oh!

Jwaegebaert commented Oct 2, 2023

Uh oh!

nanddeepn commented Oct 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Jwaegebaert commented Oct 2, 2023

Uh oh!

nanddeepn commented Oct 2, 2023

Uh oh!

nanddeepn commented Oct 2, 2023

Uh oh!

Jwaegebaert commented Oct 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

martinlingstuyl left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

martinlingstuyl commented Oct 3, 2023

Uh oh!

martinlingstuyl commented Oct 4, 2023

Uh oh!

milanholemans commented Oct 8, 2023

Uh oh!

martinlingstuyl left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

martinlingstuyl left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

martinlingstuyl left a comment

Choose a reason for hiding this comment

Uh oh!

martinlingstuyl Oct 24, 2023

Choose a reason for hiding this comment

Uh oh!

martinlingstuyl commented Oct 25, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

nanddeepn commented Oct 2, 2023 •

edited

Loading

Jwaegebaert commented Oct 3, 2023 •

edited

Loading