Hi peeps @pnp/cli-for-microsoft-365-maintainers, this is a huge PR. I'd like for us to get this in sooner rather than later, due to potential merge conflicts.

If you review this I'd suggest you start with the central files. (Command.ts, Cli.ts, prompt.ts, etc) the rest is mostly implementation of confirms across the codebase.

Hi @martinlingstuyl,
Sorry for the hold up.
I assigned myself to it and will start the review today

awesome @Adam-it, take care of checking chili and m365 setup with extra effort. A lot has been rewritten there...

I did check the setup command

and the chili

and some other scenarios like prompting for required options, to select options set etc.

Till now everything looks/works fine 👏🤩
I will continue tomorrow to go over the code and more testing. If all goes fine (no major comments) We should be ready in 2-3 days with this.
Thanks for the patience 👍

Take your time! If you have comments, I probably won't be able to fix them this week anyway. 😄

No significant comments... fantastic 😅

If you don't have anymore comments on the way it's setup, that's great! In that case we can ship it 🚀

Ow by the way. Did you get any changes in the shrinkwrap file when running npm install?

Ow by the way. Did you get any changes in the shrinkwrap file when running npm install?

actually, I did when I was rechecking tests without this additional code.
Shouldn't this change be part of the PR then?

Well, the changes were about our custom Eslint rules, which I did not change, so I was confused about them, particularly because it's a different type of npm-package: a local package, so I did not push them. What's your idea on that?

Well, the changes were about our custom Eslint rules, which I did not change, so I was confused about them, particularly because it's a different type of npm-package: a local package, so I did not push them. What's your idea on that?

O didn't actually check what changed in the shrink. But if it's not connected to your change I guess it should not occured if we merge with latest main 🤔.

@martinlingstuyl which node and npm version are you using when building this?
I checked and in our pipelines we use

This is also the same I use locally.

and only building CLI from this branch I get the following changes in shrinkwrap

and

TBH I have no idea why 😅
@pnp/cli-for-microsoft-365-maintainers could someone also recheck if has the same behavior with this branch? simply pull locally and run npm install

I'm working from the docker container and have versions:

So slight differences.
It seems like your npm install does an undo of the changes that are made by my npm install.

Hi @Adam-it, I've rebased and committed the shrinkwrap changes...

merged manually.
thank you for your awesome work 👏

And thank you for the quick merge!