Refactor spo web roleassignment add to use util instead of calling other command, Closes #5310#5311
Merged
martinlingstuyl merged 1 commit intopnp:mainfrom Apr 2, 2025
Conversation
Member
|
Thanks for another awesome PR 💪👍. You are on 🔥 also today. We will review it ASAP, but please be patient 🙏, I think the amount of open PRs supposed us a bit and we all do have other activities besides reviewing |
nicodecleyre
force-pushed
the
Refactor-spo-web-roleassignment-add
branch
from
17f9be7 to
621b6b6
Compare
Member
|
setting to draft due to the following observations |
Contributor
|
Let me have a look at this one.... |
martinlingstuyl
force-pushed
the
Refactor-spo-web-roleassignment-add
branch
from
621b6b6 to
c4d2f69
Compare
martinlingstuyl
approved these changes
Apr 2, 2025
Contributor
martinlingstuyl
left a comment
martinlingstuyl
left a comment
There was a problem hiding this comment.
Rebased, minor adjustments and approved. Thanks @nicodecleyre!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5310