Skip to content

Refactor pp solution publish to use util instead of calling other command, Closes #5248#5249

Merged
martinlingstuyl merged 1 commit intopnp:mainfrom
nicodecleyre:Refactor-pp-solution-publish
Apr 9, 2025
Merged

Refactor pp solution publish to use util instead of calling other command, Closes #5248#5249
martinlingstuyl merged 1 commit intopnp:mainfrom
nicodecleyre:Refactor-pp-solution-publish

Conversation

@nicodecleyre
Copy link
Copy Markdown
Contributor

Closes #5248

@Adam-it
Copy link
Copy Markdown
Member

Adam-it commented Jul 18, 2023

More goodies to check 🤓.
We will review it ASAP

@Adam-it Adam-it self-assigned this Aug 20, 2023
@nicodecleyre nicodecleyre force-pushed the Refactor-pp-solution-publish branch from 4d107e0 to d820079 Compare September 1, 2023 20:24
@Adam-it Adam-it marked this pull request as draft September 17, 2023 22:45
@Adam-it
Copy link
Copy Markdown
Member

Adam-it commented Sep 17, 2023

setting to draft due to the following observations
I will provide more guidance how we should proceed with this PR in near future

@martinlingstuyl martinlingstuyl force-pushed the Refactor-pp-solution-publish branch from d820079 to 4201976 Compare April 8, 2025 20:39
Copy link
Copy Markdown
Contributor

@martinlingstuyl martinlingstuyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased and updated slightly

@martinlingstuyl martinlingstuyl marked this pull request as ready for review April 8, 2025 20:39
@martinlingstuyl martinlingstuyl merged commit 4201976 into pnp:main Apr 9, 2025
9 checks passed
@martinlingstuyl
Copy link
Copy Markdown
Contributor

Merged 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor pp solution publish to use util instead of calling other command

3 participants