Skip to content

Refactores Interactive mode config key. Related #5053#5153

Closed
Adam-it wants to merge 2 commits intopnp:mainfrom
Adam-it:disambiguation-prompts-key-refactor
Closed

Refactores Interactive mode config key. Related #5053#5153
Adam-it wants to merge 2 commits intopnp:mainfrom
Adam-it:disambiguation-prompts-key-refactor

Conversation

@Adam-it
Copy link
Copy Markdown
Member

@Adam-it Adam-it commented Jun 21, 2023

🎯 Aim

The aim is to refactor the CLI logi to use prompt config for our new interactie mode

📷 Result

image

🔗 Related issue

Related #5053

Copy link
Copy Markdown
Contributor

@martinlingstuyl martinlingstuyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @Adam-it, you forgot one file though:

SetupPresets.ts

If you don't have time I'll fix it when merging. 👍 you rock!

Copy link
Copy Markdown
Contributor

@martinlingstuyl martinlingstuyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪 fantastic, you rock!

@martinlingstuyl
Copy link
Copy Markdown
Contributor

Merged manually, thank you 👏🥳

@Adam-it Adam-it deleted the disambiguation-prompts-key-refactor branch October 11, 2023 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-merged pr-priority Process this PR asap

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants