Skip to content

Fixes spo file get unit tests, clarification on id in the description#497

Closed
VelinGeorgiev wants to merge 1 commit intopnp:devfrom
VelinGeorgiev:file-get-fixes
Closed

Fixes spo file get unit tests, clarification on id in the description#497
VelinGeorgiev wants to merge 1 commit intopnp:devfrom
VelinGeorgiev:file-get-fixes

Conversation

@VelinGeorgiev
Copy link
Copy Markdown
Contributor

  • Spo file get - 3 unit tests completed, seems someone forgot to complete them.
  • I also changed the description and examples adding the UniqueId word. This might prevent ambiguity around the id since a SPList has ID (int) and UniqueId (GUID).

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling 8fd6d4e on VelinGeorgiev:file-get-fixes into 4b0e372 on SharePoint:dev.

@waldekmastykarz
Copy link
Copy Markdown
Member

Perfect! Thank you!

@waldekmastykarz waldekmastykarz self-assigned this Jun 19, 2018
@waldekmastykarz
Copy link
Copy Markdown
Member

Merged manually

@waldekmastykarz waldekmastykarz added this to the v1.4.0 milestone Jun 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants