Skip to content

Trims test output, closes #4783#4785

Closed
nicodecleyre wants to merge 2 commits intopnp:mainfrom
nicodecleyre:trim-test-output
Closed

Trims test output, closes #4783#4785
nicodecleyre wants to merge 2 commits intopnp:mainfrom
nicodecleyre:trim-test-output

Conversation

@nicodecleyre
Copy link
Copy Markdown
Contributor

Closes #4783

@milanholemans
Copy link
Copy Markdown
Contributor

Thank you @nicodecleyre, we'll have a look at it ASAP!

Comment thread package.json Outdated
@waldekmastykarz waldekmastykarz marked this pull request as draft April 22, 2023 12:12
@waldekmastykarz waldekmastykarz self-assigned this Apr 22, 2023
@nicodecleyre nicodecleyre marked this pull request as ready for review April 24, 2023 09:39
@waldekmastykarz
Copy link
Copy Markdown
Member

It seems like we've got some messy tests (output after running npm run test:test):

image

Not related to this change, but this change makes it more visible. Let's create a separate issue to find out what's wrong and fix it.

Copy link
Copy Markdown
Member

@waldekmastykarz waldekmastykarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Nothing to add 👏

@waldekmastykarz
Copy link
Copy Markdown
Member

Merged manually. Thank you! 👏

@nicodecleyre nicodecleyre deleted the trim-test-output branch May 10, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Trim test output

3 participants