Added CommentsOnListItemsDisabled parameter to spo tenant settings set cmdlet. Closes #4775#4777
Closed
ganesh-sanap wants to merge 1 commit intopnp:mainfrom
Closed
Added CommentsOnListItemsDisabled parameter to spo tenant settings set cmdlet. Closes #4775#4777ganesh-sanap wants to merge 1 commit intopnp:mainfrom
ganesh-sanap wants to merge 1 commit intopnp:mainfrom
Conversation
Contributor
|
Thank you for this PR @ganesh-sanap, we'll try to review it ASAP! |
Contributor
Author
|
@milanholemans Any updated on this PR? |
Contributor
|
Hi @ganesh-sanap, sorry for the delay. We currently have a backlog of PRs that we are trying to clear. Currently we are also in a code freeze because we will do a release this tuesday. To prevent last minute bugs, we initiate a code freeze 7 days before the next release where we don't merge PRs. We'll try to have a look at your code in the coming days! |
Contributor
Author
|
No need to apologies, thank you for the updates @milanholemans! |
milanholemans
approved these changes
May 2, 2023
Contributor
milanholemans
left a comment
milanholemans
left a comment
There was a problem hiding this comment.
Looks good to me, nothing to add!
Contributor
|
Merged manually, thank you for this addition! 👏 |
Contributor
Author
|
@milanholemans Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Related Issues?
Closes #4775
What is in this Pull Request ?
Added
--CommentsOnListItemsDisabledparameter tospo tenant settings setcmdlet which allows enabling/disabling comments on SharePoint lists at tenant level.