Skip to content

Updates pp tenant settings list response#4759

Closed
milanholemans wants to merge 1 commit intopnp:mainfrom
milanholemans:docs-settings-list
Closed

Updates pp tenant settings list response#4759
milanholemans wants to merge 1 commit intopnp:mainfrom
milanholemans:docs-settings-list

Conversation

@milanholemans
Copy link
Copy Markdown
Contributor

@milanholemans milanholemans commented Apr 12, 2023

Noticed that the response of pp tenant settings list has been updated by the API.

@Adam-it Adam-it self-assigned this Apr 18, 2023
Adam-it
Adam-it approved these changes Apr 18, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@Adam-it Adam-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that is correct ✅
double checked locally 👍
@milanholemans awesome catch 🪝
you rock 🤩

@Adam-it
Copy link
Copy Markdown
Member

Adam-it commented Apr 18, 2023

ready to merge 🚀

@Adam-it
Copy link
Copy Markdown
Member

Adam-it commented Apr 18, 2023

BTW I think we will have more and more specs with md output where we should remove the complex objects now after latest changes merged to main 🤔
I will double check it and open a separate issue for it ... unless there already is one 😉

@milanholemans
Copy link
Copy Markdown
Contributor Author

milanholemans commented Apr 18, 2023

Unfortunately yes ☹️ same goes for the CSV output.

@milanholemans
Copy link
Copy Markdown
Contributor Author

milanholemans commented Apr 18, 2023

I question if we should remove csv from the trimmed outputs now?
Can't quite follow all these output changes.

@Adam-it
Copy link
Copy Markdown
Member

Adam-it commented Apr 18, 2023

I question if we should remove csv from the trimmed outputs now? Can't quite follow all these output changes.

that's ok. You already are doing SO MUCH.. I will try to take this one on me 👍. Will double check this in up coming days

@Adam-it
Copy link
Copy Markdown
Member

Adam-it commented Apr 19, 2023

Merged manually. Thanks for your awesome work 🤩

@Adam-it Adam-it closed this Apr 19, 2023
@milanholemans milanholemans deleted the docs-settings-list branch April 19, 2023 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Adam-it Adam-it Adam-it approved these changes

Assignees

@Adam-it Adam-it

Labels

docs pr-merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@milanholemans @Adam-it