Adds spinner to communicate command running#4536
Closed
waldekmastykarz wants to merge 1 commit intopnp:mainfrom
Closed
Adds spinner to communicate command running#4536waldekmastykarz wants to merge 1 commit intopnp:mainfrom
waldekmastykarz wants to merge 1 commit intopnp:mainfrom
Conversation
waldekmastykarz
force-pushed
the
spinner
branch
from
fe3d11b to
39f7a36
Compare
Contributor
|
Great job @waldekmastykarz! I love it! |
Member
Author
|
Thanks! It's great how it adds some responsiveness, isn't it? |
Contributor
|
Sure does! |
plamber
approved these changes
Feb 25, 2023
Contributor
plamber
left a comment
plamber
left a comment
There was a problem hiding this comment.
Thank you. Manually merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cli-m365-spinner.mp4
Adds spinner to communicate command running for all commands.
Removes the obsolete dots for a several commands that we're doing manually.
Uses new dependency, ora, to render the spinner.