Added docs section for starting contributors#4456
Added docs section for starting contributors#4456Jwaegebaert wants to merge 6 commits intopnp:mainfrom
Conversation
|
Awesome work @Jwaegebaert . We will review it ASAP 🤩 |
|
@garrytrinder, I believe you had some ideas in this space. Would you mind reviewing this PR? |
|
Great work @Jwaegebaert 👏 I've had a quick look and here are some of my initial thoughts.
|
|
Great pointers @garrytrinder! I've got a few questions.
Do you maybe know how we can achieve this with
This was my initial thought also, but won't it be easier for users to have a fully implemented example? That way they can always validate the existing files in the project and reflect on this. |
|
Apologies on the delay on getting back to you on this, life has been getting in the way.
This could just be a couple of buttons, or even simpler just a bulleted list.
It might be easier, but as the tutorial is aimed at folks with no prior knowledge, we could guide them through setting up the development environment, starting watch mode, build and run a command and then write the tests. This would show the contributor the full end to end process and at the end they have built something from scratch. This would be a great way to learn. It's also a good way to show the developer experience. |
d15e9f8 to
d9d8abd
Compare
|
Alright, it has been a while since I last updated this PR. Here are the changes I have made:
I want to mention that I haven't incorporated the suggestions for the new command example. Personally, I believe it is much easier for users to understand and follow a real-world scenario rather than a hypothetical one. This way, users can also refer to the fully implemented files to compare their own scenarios. |
|
Do you need help on this one @garrytrinder? It would be nice if we can merge it before the migration to docusaurus. |
|
@Jwaegebaert, @garrytrinder: just to get the lay of the land: how far along is this PR? Do you think it's just crossing some t's and dotting some I's? Or might more zealous reading be in order? |
|
Some zealous reading is always welcome 😄 I've done a second round of adjustments so it could always do with some tweaks here and there. But with Docusaurus around the corner like you said. We'll need to make some adjustments to this guide to include the Docusaurus architecture |
|
In that case maybe we should leave it until after the docusaurus release... |
milanholemans
left a comment
There was a problem hiding this comment.
We've recently changed our SSG to Docusaurus. This update has impacted our documentation syntaxes and will require some adjustments on your end. However, there's no need to worry, as Milan has done an amazing job creating a detailed page that explains all the new syntaxes to be used in the .mdx files. If you have any questions, feel free to reach out to us here or on Discord. You can find more information at this link: All you need to know about Docusaurus.
😉
|
Closing this to test Parker |
This had fallen off my list, however now that Docusaurus release has happened it seems like a good time to revisit this. |
d9d8abd to
c05d2bf
Compare
|
It's been updated to include all the changes regarding Docusaurus |
garrytrinder
left a comment
There was a problem hiding this comment.
Great work @Jwaegebaert! Please find my initial comments. I've not had chance to review all pages, so this review is ongoing, but wanted to provide some initial feedback for you to consider.
|
Awesome initial review @garrytrinder, I've already applied most of these. |
garrytrinder
left a comment
There was a problem hiding this comment.
Thanks for the updates @Jwaegebaert here are some more comments 👍
milanholemans
left a comment
There was a problem hiding this comment.
Hi, @Jwaegebaert awesome work! A lot of valuable content!
I noticed this PR has been stale for a while so I checked your PR (because I find this topic interesting), and noticed some outdated info. I'm not trying to take over @garrytrinder 's role; he's doing great. Just wanted to share my observations and help improve the content.
Keep up the good work!
|
|
||
| ## You have an idea for a New Command | ||
|
|
||
| Awesome! Good ideas are invaluable for every product. Before you start hacking away, please check if there is no similar idea already listed in the [issue list](https://github.com/pnp/cli-microsoft365/issues). This ensures that your idea is unique and not being worked on. If you don't find a similar idea, create a new issue describing your idea. Once we agree on the feature scope and architecture, the feature will be ready for building. Don't hesitate to mention this in the issue if you'd like to build the feature yourself. If it's the first time you're building a command, see the [guidance article](https://github.com/pnp/cli-microsoft365/wiki/Adding-a-command) explaining in detail what you will need at a minimum. |
There was a problem hiding this comment.
For guidance article, is there no page we can use on our website? Will the wiki still be available when this PR completes?
There was a problem hiding this comment.
Right now, there's no specific page for this, but it would be great to have one on the website. Maybe we can create a new issue to address this. We'll review the existing wiki pages and make sure to remove any links if we decide to move the content there.
|
Nice review @milanholemans, very thorough! Most suggestions are applied. One thing I was curious about, I noticed there weren't any suggestions regarding the file |
I left 1 comment there 😃. From what I can remember, that page was good 👍 |
|
@pnp/cli-for-microsoft-365-maintainers can we give this PR a shot and merge it in? 😄 |
|
@Jwaegebaert LGTM 🚀 |
|
Merged manually, nice work @Jwaegebaert! |
Finally, after a few months of work, lots of head-scratching, I can deliver the first design for a new section in the docs. A guide on how to get started with contributing to the CLI for Microsoft 365.
The following topics are included in this section.
@pnp/cli-for-microsoft-365-maintainers a thorough review would be nice 😄
Closes #2834