Adds tracking shell to telemetry#3769
Closed
waldekmastykarz wants to merge 1 commit intopnp:mainfrom
Closed
Conversation
Member
|
thanks @waldekmastykarz for this awesome PR. We'll review it ASAP 😉 |
milanholemans
added
the
hacktoberfest-accepted
Member
Author
|
Merged manually |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds tracking shell to telemetry.
Main changes are done in:
Also, modifies a lot of test files to stub retrieving the process name from pid. When you run tests, you'll get a cache file created in the CLI cache folder at
tmpdir/cli-microsoft365-cache. This is unfortunately inevitable, because pid is mocked after tests start. The good news is, that expired cache files are cleared after 24h and on each run of the CLI, so the side-effect is only temporary.If you look at cache tests, you'll see that the test date is set to two days ago instead of yesterday. This is, because if tests run too fast (and this happens only sometimes), setting the date to one day back, doesn't meet the condition of older than 24 hours. Setting it to two days earlier addresses this issue in a simple way.